Skip to content

feat(web): Improve download page and image handling#1622

Merged
ComputelessComputer merged 1 commit intomainfrom
jj-branch-10
Nov 4, 2025
Merged

feat(web): Improve download page and image handling#1622
ComputelessComputer merged 1 commit intomainfrom
jj-branch-10

Conversation

@ComputelessComputer
Copy link
Collaborator

@ComputelessComputer ComputelessComputer commented Nov 4, 2025

  • Replace local image with Supabase-hosted image
  • Add Apple Silicon download route with redirect
  • Update download button to link directly to download
  • Optimize image loading with custom Image component
  • Remove unnecessary separators in download page
  • Enhance route configuration for better navigation

@ComputelessComputer
feat(web): Improve download page and image handling
adf5c70 
- Replace local image with Supabase-hosted image
- Add Apple Silicon download route with redirect
- Update download button to link directly to download
- Optimize image loading with custom Image component
- Remove unnecessary separators in download page
- Enhance route configuration for better navigation
@ComputelessComputer ComputelessComputer merged commit e433103 into main Nov 4, 2025
2 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR migrates image assets across multiple routes from local/relative paths to remote URLs by replacing standard img elements with an Image component. Concurrently, it refactors the download flow to use direct browser navigation via anchor tags instead of client-side routing, introduces a new redirect route for apple-silicon downloads pointing to an external URL, and updates related download link targets throughout the navigation.

Changes

Cohort / File(s) Summary
Image Component Migration to Remote Assets
apps/web/src/routes/_view/index.tsx, apps/web/src/routes/_view/pricing.tsx, apps/web/src/routes/auth.tsx		 Replaced standard img elements with Image component throughout multiple sections. Updated image sources from local paths to remote Supabase URLs. Added explicit width and height props. Added fallback rendering for missing feature/detail images.
Download Flow Refactoring
apps/web/src/components/download-button.tsx, apps/web/src/routes/_view/route.tsx		 Replaced router Link usage with standard anchor tags pointing to /download/apple-silicon. Applied to download button, header/footer CTAs across desktop and mobile variants. Added download attribute to anchor tags. Shifted from client-side routing to direct browser navigation.
Download Routing & Redirect Setup
apps/web/src/routes/_view/download/apple-silicon.tsx (new), apps/web/src/routes/_view/download/index.tsx		 Created new route file with external redirect to https://desktop.hyprnote.com/download/latest/dmg-aarch64?channel=stable via beforeLoad hook. Updated download index route path from /_view/download to /_view/download/. Updated DownloadCard links to use /download/apple-silicon. Migrated index route image assets to Image component with remote URLs.

Sequence Diagram

sequenceDiagram
    actor User
    participant DownloadBtn as Download Button
    participant Router as Router (TanStack)
    participant AppleSilicon as /download/<br/>apple-silicon Route
    participant External as External URL

    User->>DownloadBtn: Click download
    DownloadBtn->>Router: Navigate to /download/apple-silicon
    Router->>AppleSilicon: Load route
    AppleSilicon->>AppleSilicon: beforeLoad hook triggered
    AppleSilicon->>External: Redirect to desktop.hyprnote.com
    External-->>User: Download starts
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

Areas requiring extra attention:

  • Verify the external redirect URL in apple-silicon.tsx is accessible and correctly configured
  • Confirm all download link changes across button, header, footer, and route components are consistent
  • Validate that remote image URLs from Supabase are functional and loading properly in all affected routes
  • Check that the download attribute placement on anchor tags is compatible with the download routing behavior

Possibly related PRs

  • landing-2 #1598: Directly modifies download-button.tsx—the initial component creation that this PR refactors from Link to anchor tag navigation.
  • landing #1617: Modifies apps/web/src/routes/_view/index.tsx with similar image-to-Image component migrations and remote asset URL updates.
  • landing-3 #1599: Updates download link navigation in apps/web/src/routes/_view/route.tsx header and footer, overlapping with this PR's CTA refactoring.

Suggested reviewers

  • yujonglee
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jj-branch-10
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d6f8a3 and adf5c70.

⛔ Files ignored due to path filters (2)
  • apps/web/public/static.gif is excluded by !**/*.gif
  • apps/web/src/routeTree.gen.ts is excluded by !**/*.gen.ts
📒 Files selected for processing (7)
  • apps/web/src/components/download-button.tsx (2 hunks)
  • apps/web/src/routes/_view/download/apple-silicon.tsx (1 hunks)
  • apps/web/src/routes/_view/download/index.tsx (4 hunks)
  • apps/web/src/routes/_view/index.tsx (8 hunks)
  • apps/web/src/routes/_view/pricing.tsx (2 hunks)
  • apps/web/src/routes/_view/route.tsx (4 hunks)
  • apps/web/src/routes/auth.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Nov 6, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 19, 2025
Merged
This was referenced Nov 27, 2025
Merged
Merged
Merged
@ComputelessComputer ComputelessComputer deleted the jj-branch-10 branch December 14, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ComputelessComputer

Comments